describegpt: add testing (resolves #1114) #1115

rzmk · 2023-07-06T21:46:05Z

🗺 Overview

Resolves #1114.

test_describegpt.rs file for reference.

src/cmd/describegpt.rs

jqnatividad

LGTM! Thanks @rzmk !

describegpt: add describegpt to tests.rs

7ff8e2f

rzmk marked this pull request as draft July 6, 2023 21:46

rzmk changed the title ~~describegpt: add describegpt to tests.rs~~ describegpt: add testing (resolves #1114) Jul 6, 2023

rzmk added 13 commits July 7, 2023 05:42

describegpt: invalid_api_key test

7100ac1

describegpt: add valid and valid JSON tests

ecc217e

describegpt: run cargo +nightly fmt

52d39f1

describegpt: attempt debug with error output

86a6dc0

describegpt: fix to --nocapture

a6cd071

describegpt: use canonicalize when getting input

dd6fae7

describegpt: attempt using current_dir with tmpdir path

57822df

describegpt: use root for qsv path akin to workdir

b1febef

describegpt: use root path to qsv directly & --max-tokens to tests

984b4f0

describegpt: remove --no-capture & unnecessary mut for root

4f830df

describegpt: remove print in invalid_api_key test

b54ca18

describegpt: --user-agent test

2ccce07

describegpt: run cargo +nightly fmt

c4459f8

rzmk marked this pull request as ready for review July 7, 2023 16:33

rzmk requested a review from jqnatividad July 7, 2023 16:36

rzmk commented Jul 7, 2023

View reviewed changes

src/cmd/describegpt.rs Outdated Show resolved Hide resolved

describegpt: update comment to specify qsv path not dir

e03c7bb

jqnatividad approved these changes Jul 7, 2023

View reviewed changes

jqnatividad merged commit 192d8ad into master Jul 7, 2023

rzmk deleted the describegpt/testing branch July 14, 2023 15:46

moonfruit mentioned this pull request Jul 17, 2023

qsv 0.109.0 Homebrew/homebrew-core#136785

Merged